OpenGen Questions & Bugs - Latest exe: 0.93.3.8.Test (1-Dec-2019)

Discussing the game, editor (Suite) and the related tools.
User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by lvjtn » 2019-11-10 16:57, Sunday

LuisGuzman wrote:
2019-11-10 13:08, Sunday
Maybe I should rethink such solution :dunno
you still can use a dat file collection similar to the icons or the old pg2 dossier.shp, etc. :dunno
randowe wrote:
2019-11-10 13:53, Sunday
Is it possible to have no-read lines in the names.txt?
it seems it's not possible, though the idea is great! :yes

btw. i always tought the first 31 lines are the genreic names what opengen use for the nations not having leader names. but now i made a quick test filees with only 62 lines, and opengen doesn't use the first 31 lines for nation #10. is it a bug, or the role of the first 31 lines is something else?
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by LuisGuzman » 2019-11-10 19:40, Sunday

lvjtn wrote:
2019-11-10 16:57, Sunday
randowe wrote:
2019-11-10 13:53, Sunday
Is it possible to have no-read lines in the names.txt?
...
So i want to ask if it is possible to divide the nations with no-read lines like in the other text files. Something like:

***1***Slovakia***********
***8***Germany***********
it seems it's not possible, though the idea is great! :yes
Currently the leader name is assigned when a leader is raised by this formula (inherit from Pg2):

Code: Select all

leader->id = unit->country*31+RollDice(0,30);
leader->name = text of the leader->id line of names.txt
That is: the first 31 entries are not used at all.

Names.txt is opened whenever a new leader is raised to load the line according the "leader->id" assigned and then is closed.
That "leader->id" is stored in the savegames, so when a savegame is reloaded, names.txt is opened again and the the "leader->name" is retrieved from the line pointed by the "leader->id" stored.
btw. i always thought the first 31 lines are the generic names what opengen use for the nations not having leader names. but now i made a quick test files with only 62 lines, and opengen doesn't use the first 31 lines for nation #10. is it a bug, or the role of the first 31 lines is something else?
Names.txt is the same than used by PG2 ... and first 31 entries was not used by PG2 either.

Once said this ...
To remove the unused 31 entries, names.txt should be converted to NamesEx.txt

To allow inserting comments at start of country's names entries in names.txt or namesEx.txt, by using starting tokens in lines to be skipped (like *** or whatever) I'd only need to tweak the code to figure the random leader->id inside the function in charge of reading the text file (names/namesEx).

The only drawback could be that leaders' names in existing savegames (xsav, xcsv, xeml) will load a different leader name if their efile's name/namesEx text file is modified to include commented (***) lines.
:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by lvjtn » 2019-11-10 21:22, Sunday

LuisGuzman wrote:
2019-11-10 19:40, Sunday
That is: the first 31 entries are not used at all.
:doh i lived 20 years in complete ignorance :beatup

anyway, the NamesEx.txt sounds interesting, separating the nations by a commented line would help a lot, i guess. as the savefiles are temporal, i don't see any real drawback :2cents
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by randowe » 2019-11-10 22:38, Sunday

lvjtn wrote:anyway, the NamesEx.txt sounds interesting, separating the nations by a commented line would help a lot, i guess. as the savefiles are temporal, i don't see any real drawback :2cents
I second that :cool

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by mythos » 2019-11-11 13:27, Monday

LuisGuzman wrote:
2019-11-10 13:08, Sunday
mythos wrote:
2019-11-09 23:52, Saturday
Yes, i do see the Dossier (portrait and medals). I also see medals when inspecting a unit.
However, i don't see Leader portraits when inspecting a unit :fused
...
Still, i think it has something to do with the width of the files.
I assume that roundels and Leader portraits are loaded "in full" (i get an error message when inspecting a unit with LXF, that the size is too large), while Dossier portrait and both medals types are internally cut by the game to single pieces ?
Either way however, it seems that it is a hardware issue on my side.
Yes, this is a hardware issue :yep

[..]

I honestly didn't realize that D3D could impose a restriction on the size of textures, when the much older DirectDraw didn't make such restriction, and thus I concluded that it was much easier to load the whole file.
:huh Maybe I should rethink such solution :dunno
Do i understand correctly: the problem is simply that my video card is lacking OpenGL support ?
If not, could you please detail what else the card would need to "fix" the issue ?

Imho, considering that i am the only one having the issue and that it didn't occur earlier, the simplest thing would be that i get a new video card (i was aware that it is insufficient for gaming, since the computer was formerly an office setup (literally) - and i have trouble with other games which require OpenGL).
The short story is, i was lacking the funds for a high-end machine, however needed a "new" PC now, so i got myself a cheap system plus extra RAM from the friend of a friend, as well as a SATA HDD.
Investing in some kind of OpenGL video card is fine for me, since i need to do it anyway :yep


Edit:
Dunno if it helps, the current video card is: Intel Q45
Image

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by LuisGuzman » 2019-11-11 15:08, Monday

Support for OpenGL is not required to play OpenGen in a windows system, sdl2 would use D3D as default.

Can check this page: https://www.intel.com/content/www/us/en ... ivers.html
3D graphics features
  • ...
  • Full OpenGL* 1.3 ICD (Installable Client Driver)
  • Compatible with DirectX* 9.0, 8.x, and 7.x
  • Specific features of DirectX 9.0 are supported
  • ...
  • Texture Engine
  • Up to 2048x2048 texture size
  • All texture formats including 32-bit RGBA and 8-bit palette
  • Alpha and Luminance maps
  • Texture ColorKeying/ChromaKeying
Although it looks like you can use 4096x4096 textures, so it is possible that you have updated drivers for your Q45 :dunno

I also found this other report, which seems that the Intel(R) Q45/Q43 Express Chipset Driver Version 8.15.10.2413 can use textures up to 4096x4096
https://h30434.www3.hp.com/t5/Desktops- ... -p/6056216

Win version can also impose additional restrictions ... but I could not find any other report telling how to use bigger textures, sorry.
:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.0 (15-Oct-2019)

Post by mythos » 2019-11-11 15:36, Monday

:eek :banana
Driver update indeed solved the issues. Crazy thing though: according to date, the drivers i had before were newer :fused :whatever

Thank you very much Luis :bow


Edit:
this also solved the trouble with some of the other games.
Image

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by LuisGuzman » 2019-11-12 18:39, Tuesday

:bullhorn OpenGenTest.exe 0.93.3.3.Test is available

Including:
  • Leaders' names are stored in the savegames.
  • Leader's names can be read from either names.txt or from namesEx.txt
  • namesEx.txt must not include the unused first dummy 31 entries.
  • Either names.txt or namesEx.txt and can include comment lines starting with token * (asterisk)
  • Optimized loading medals and photos (dossier and inspect) to load only the image/s needed.
  • optional og_forums.png was reported as missing, after closing the game. It won't complain anymore if not present, as it is needed only for testing.
:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by lvjtn » 2019-11-12 19:38, Tuesday

LuisGuzman wrote:
2019-11-12 18:39, Tuesday
  • Leaders' names are stored in the savegames.
  • Leader's names can be read from either names.txt or from namesEx.txt
  • namesEx.txt must not include the unused first dummy 31 entries.
thanks, Luis

unfortunately, something is not perfect with NamesEx, like either the first 31 lines would be still ignored or the commented lines wouldn't be ignored, in my test scenario (efile son), the texian unit picks up a name from the mexican roster, which is the next nation. the files are on their way to you
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by LuisGuzman » 2019-11-13 09:10, Wednesday

lvjtn wrote:
2019-11-12 19:38, Tuesday
unfortunately, something is not perfect with NamesEx, like either the first 31 lines would be still ignored or the commented lines wouldn't be ignored, in my test scenario (efile son), the texian unit picks up a name from the mexican roster, which is the next nation. the files are on their way to you
:doh

The line detecting if Names.txt or NamesEx.txt is loading was buggy and never detects NamesEx.txt

Can get 0.93.3.4.Test from same link fixing it!
:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by mythos » 2019-11-13 18:05, Wednesday

Thanks Luis :bow
LuisGuzman wrote:
2019-11-12 18:39, Tuesday
  • Optimized loading medals and photos (dossier and inspect) to load only the image/s needed.
  • optional og_forums.png was reported as missing, after closing the game. It won't complain anymore if not present, as it is needed only for testing.
I confirm it working with the "buggy" (texture size) drivers :twink
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by lvjtn » 2019-11-13 20:04, Wednesday

LuisGuzman wrote:
2019-11-13 09:10, Wednesday
Can get 0.93.3.4.Test from same link fixing it!
it does, 0.93.3.4.Test solved the NamesEx.txt issue :thanks :bow
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by LuisGuzman » 2019-11-14 13:22, Thursday

LuisGuzman wrote:
2019-11-13 09:10, Wednesday
lvjtn wrote:
2019-11-12 19:38, Tuesday
unfortunately, something is not perfect with NamesEx, like either the first 31 lines would be still ignored or the commented lines wouldn't be ignored, in my test scenario (efile son), the texian unit picks up a name from the mexican roster, which is the next nation. the files are on their way to you
:doh

The line detecting if Names.txt or NamesEx.txt is loading was buggy and never detects NamesEx.txt

Can get 0.93.3.4.Test from same link fixing it!
:howdy
Can get 0.93.3.5.Test fixing a minor issue when loading dossier graneral name (same links)
:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.3.Test (12-Nov-2019)

Post by lvjtn » 2019-11-14 17:10, Thursday

LuisGuzman wrote:
2019-11-14 13:22, Thursday
Can get 0.93.3.5.Test fixing a minor issue when loading dossier graneral name (same links)
thanks, the bug is fixed :yes :bow i could finish a few more nations for son efile much faster :banana
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by mythos » 2019-11-16 13:26, Saturday

Hola Luis :howdy

Could you please check this NamesEX bug ?
Maybe it is hidden somewhere else, but i noticed it today morning while adding the NamesEx file.
I haven't fully figured out where the problem sits (i was interrupted by my :sweetwife ). So far i only managed to find out, that it has something to do with Efiles featuring a lot of Nations (LXF, FTL, GUS and Kaiser) and that it happens somewhere past Nation #55 (*), at least i assume this.

The issue is, that at some point Name #01 of Nation X slips to Nation X-1:
Image


(*) LXF and FTL have a Nation with a very long Nation name (apparently breaking the max ## of characters) at slot #55. After abbreviating the name to fit the formats, i deleted NamesEX and let Suite create a fresh NamesEx file, but the above issue was persistent - i only saw that at Nation #55 the Names are in order. I didn't check the 54 nations before, but instead went to the end of the file and started looking upward from there
Image

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by LuisGuzman » 2019-11-16 14:20, Saturday

I've made a quick test with LXF's names and I found suspicious that Ecuador (#73) have a leader named Abbott, and from there the last name of each country looks like it belonging to the next country, as if Ecuador had only 30 leaders' names instead of 31 :idea

It is not as easy to check with every country, but for example it is noticeable also with the last leader name for State of Vietnam (#79) being Murphy, which is more likely belonging to Ireland (#80).

I added a name for Ecuador('Ecuador31') as line 2295 and all "empty" countries was aligned as well as the last "German Empire" country.
Maybe the missing line was before Ecuador, but I was not able to find where else ...

This shows that Clemens's suggestion to add comment lines to identify better the leaders' entries for each country was a big improvement :notworthy
:bow :bow :bow
:clap :clap :clap
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by mythos » 2019-11-16 14:58, Saturday

Thanks Luis :bow

I have just arrived at Ireland and found indeed the slipped "Murphy".
Not finding the slip earlier is rather simple: there are a lot of Portugese/Spanish speaking countries before - Abbott somehow evaded me :doh
(now that you mention it...why haven't i used notepad+ for this, it has a counter for lines at the side and would have showed me the missing line earlier :banghead )

And agreed, this update is great (i am a little control and sorting freak, so, yeah, having lines for Names is great :goodie
Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by randowe » 2019-11-23 01:15, Saturday

:howdy

My questions is about the hovercraft movement method. I read at JP's but i still have some fear. I changed the hovercraft movement method into a horse movement method. I don't need hovercraft but wanted a combination of tracked/leg for my recon cavalries. I tested it and everything plays right.

Now i want to ask if there will be any issues when turning the hovercraft movement into a custom aka horse movement method? Sorry, i know that has been asked before but i am so fearful and cautios :bonk :bonk

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by mythos » 2019-11-23 08:00, Saturday

The tricky move methods are
a) the ones which can be mounted
- 3, 4, 11, 14
b) the ones which the AI uses for specific tasks
- 5, 6, 7, 10, 13

Please note that the numeration starts with 0.

Otherwise, the move methods can be played around with (as far as i remember).
Last edited by mythos on 2019-11-23 08:52, Saturday, edited 1 time in total.
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by lvjtn » 2019-11-23 08:35, Saturday

mythos wrote:
2019-11-23 08:00, Saturday
a) the ones which can be mounted
- 3, 4, 11
and 14 (custom #1)
randowe wrote:
2019-11-23 01:15, Saturday
Now i want to ask if there will be any issues when turning the hovercraft movement into a custom aka horse movement method?
if you don't need gtp, then there is no problem
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
mythos
Second Lieutenant
Second Lieutenant
Posts: 299
Joined: 2019-09-30 19:37, Monday
Location: near a faerie forest in a misty vale

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by mythos » 2019-11-23 08:53, Saturday

Thanks Csaba :bow

I edited my post accordingly.
Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.5.Test (14-Nov-2019)

Post by randowe » 2019-11-23 09:55, Saturday

:gracias Thanks guys :notworthy

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by LuisGuzman » 2019-11-28 13:06, Thursday

:bullhorn New OpenGenTest.exe 0.93.3.7.Test available.

1. Equipment size increased to 11000 (0..10999) units.

2. Can define a default win/loss video for scenarios/campaigns defining a "result" video (BV/LS) which is not found in the player install.

These videos must be called: scen_won, scen_lost, cam_won and cam_lost (.avi) respectively for scenario win/loss and campaign win/loss, and obviously they are not played if OG's settings disables videos :naughty.

The idea is to include in future installers these 4 (short) videos in the main SMACK folder.

:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-11-30 13:24, Saturday

Hello Luis :howdy

With the latest Test Version i have problems to display my leader pictures from inspect_portrait.png in the game.
I am already trying to figure out for 3 or 4 hours now why it is displayed wrong, but have no clue.

Then i found out that the Composite Efile has the inspect_portrait named inspect_leader and i did the same and now it works.
What is the difference between inspect_portrait and inspect_leader?
I want to keep the filesize small and use only one line of leader pictures, like the Composite efile.
Is that the point?

I post a picture with file name inspect_portrait. You can see the same unit, one time with OG 0.93.3.0 and one time with test version 0.93.3.7.
Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-11-30 16:20, Saturday

Hello again :howdy

There is another issue with the latest test exe. Same inspect unit panel as before:
When i have a army with units from various nations and inspect the units, the inspect_medal is not updated and stays the same for alle nations when i cycle through the units with the left and right arrows. I tested with KAISER too, so it is not related to my efile :phew

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by sympatyk » 2019-11-30 17:33, Saturday

:howdy
Hello Randowe
I checked the game engine - OpenGen93-3-7Test.exe
I'm using the file - inspect_portrait.png
Everything is displaying well
I've never heard of inspect_leader ..
What color depth do you use?

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-11-30 17:40, Saturday

I am using 24 bit like everyone else. I don't know what happened because i have the problem only since the latest test version.
And i have not heared of the inspect_leader.png too, until i found it today in the COMWW2 Efile.
I tested for many hours today and check many efiles but could not find out what is wrong -> see picture i posted.

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by sympatyk » 2019-11-30 18:00, Saturday

:howdy
I just used the file - inspect_portrait.png 24 bit color
It's like you write -> portraits are not displayed!
I always make 16 bit color files and I use such -> convert to 16 bit color and check in your game ..

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by sympatyk » 2019-11-30 18:34, Saturday

Sorry,
I did make a mistake when changing files (one letter)
It also works for me - 24 bit version ...
You have to - keep looking .. Sorry

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by lvjtn » 2019-11-30 19:35, Saturday

randowe wrote:
2019-11-30 13:24, Saturday
With the latest Test Version i have problems to display my leader pictures from inspect_portrait.png in the game.
i've tested some opendat files, and the problem is not using inspect_leader.png (single line) instead of inspect_portrait.png (15 lines), but the type of the png file. if any of these two files is only 8-bit (256-colors), then it's not displayed, and if any of these files is 24-bit (true color), then it's displayed

and this bug happens with the latest official exe (0.93.3.0) too

i tested it with cc20 (fyi, Luis)

edit: efile_comww2 has 8-bit inspect_leader file now, efile_son has a 24-bit inspect_leader, so they can be used for testing too

edit2: and yes, it's my fault, i never should have executed the script cleaning alpha channel when Chris reported his problem, as my solution made more troubles than goods :bonk :-o :banghead
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by sympatyk » 2019-11-30 22:14, Saturday

It is as Csaba wrote
8 bit file -> not working
If this file is saved with a color depth of 24 bit (despite using only 255 colors) -> it will recover

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-11-30 23:00, Saturday

Are we all talking about the same problem? :huh
I use 24 bits and all other efiles i checked use 24 bits too. COMWW2 inspect_leader has 24 bits too.
And i don't understand what Csaba's script has to do with the efiles inspect_leader or inspect_portrait. Or was something changed with the OG game's exe too?
But yes, it is the second time i have problems after the png script was executed. I mean, i work on the files more than a year and never had problems previously. I have no idea :dunno :lol
But now, with 24 bit inspect_leader it works for me. Somehow :huh

Please do not forget the other issue:
There is another issue with the latest test exe. Same inspect unit panel as before:
When i have a army with units from various nations and inspect the units, the inspect_medal is not updated and stays the same for alle nations when i cycle through the units with the left and right arrows. I tested with KAISER too, so it is not related to my efile. It is related to the latest test.exe.
Does anybody else (players and efile makers) use the newest versions and experienced the same problems?

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by lvjtn » 2019-12-01 00:02, Sunday

randowe wrote:
2019-11-30 23:00, Saturday
Are we all talking about the same problem? :huh
i checked the bug what you reported and found a conclusion what seems to be valid for me
I use 24 bits and all other efiles i checked use 24 bits too. COMWW2 inspect_leader has 24 bits too.
as you didn't share your files, i can't tell anything about them, but composite inspect_leader is definitely not a 24-bit file now in the repo:

Image
And i don't understand what Csaba's script has to do with the efiles inspect_leader or inspect_portrait.
i made a quick fix for Chris' problem which removed the alpha channel of all png files in the repo, but apparently it also reduced those files to 8-bit which use less than 256 colors, and it seems it's better to keep opendat files in 24-bit, no matter how many colors they use
When i have a army with units from various nations and inspect the units, the inspect_medal is not updated and stays the same for alle nations when i cycle through the units with the left and right arrows.
it would be nice to get your savefile to test it :p
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-12-01 00:30, Sunday

I just created and edited a savegame, so you can test the second bug.

As for the first one, well ,i think we don't understand each other and i will let it down. Damn english :lol I had that bug i was reporting with the pictures NOT in the version 0.93.3.0. Only in the latest test exe. Thats why i posted two pictures, to demonstrate the difference. So probably you found another bug.
Anyway, it doesn't matter if anybody else (the people who use the latest testexe) do not experience the same issues than me.

But please, can somebody answer my first question? What is the difference betwen the inspect_leader and inspect_portrait. Is it just the size/lines, what is different? Is it safe to use the "old" inspect_leader file name and just one line of leader pictures?

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by LuisGuzman » 2019-12-01 08:17, Sunday

I am sorry that I am out of town and cannot check right now, but I'd bet the problem is because when loading photos and medals, the last executable extracts only the picture required for the country to show, and surely the palette is not copied properly during this copy/paste into the texture created as it is done when loading maps made of 256 colors.

I'll check if I can fix, so wait a bit before rolling back the changes in opendat files
:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by lvjtn » 2019-12-01 08:53, Sunday

randowe wrote:
2019-12-01 00:30, Sunday
What is the difference betwen the inspect_leader and inspect_portrait. Is it just the size/lines, what is different? Is it safe to use the "old" inspect_leader file name and just one line of leader pictures?
yes the difference is the number of lines. if you use inspect_leader, then all your leadered units will have the same picture when you inspect them. if you use inspect_portrait with 15 lines, then your leadered units pick up different pictures. and yes, it's safe to use any of them

***

regarding your "first bug" (inspect leader is not displayed): you wrote this later:
But now, with 24 bit inspect_leader it works for me. Somehow
so i guess we were speaking about the same bug, or at least i cannot reproduce anything else. i see all leader protraits (no matter which file they are coming from), IF the file is a 24-bit png. what is interesting no oter files (medals, flags, roundels) should be 24-bit. so if Luis says the leaders' portriats should be 24-bit, i can fix them in the repo

***

regarding your "second bug" (the nation of the leader's portrait doesn't change):

yes, it's confirmed: it worked with 0.93.3.0 but doesn't work with the latest test. when i select a unit and inspect it, everyting is fine, the unit has a good portrait belonging its own nation, but when the ""previous" and "next" buttons are used to inspect another unit (w/o closing the inspect panel), the nation is not changed, just the portrait

thanks the test file!
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-12-01 09:35, Sunday

lvjtn wrote:
2019-12-01 08:53, Sunday
randowe wrote:
2019-12-01 00:30, Sunday
But now, with 24 bit inspect_leader it works for me. Somehow
so i guess we were speaking about the same bug, or at least i cannot reproduce anything else. i see all leader protraits (no matter which file they are coming from), IF the file is a 24-bit png. what is interesting no oter files (medals, flags, roundels) should be 24-bit. so if Luis says the leaders' portriats should be 24-bit, i can fix them in the repo
Sorry, maybe i was not exact enough with my statement. I was using 24 bit inspect_portrait with one line for more than a year and yesterday the new result was shown in the picture i posted -> the portrait was cut and only a little slice was shown. Then, yesterday too, i tried to examine the issue for hours but couldn't find anything wrong. Now i use 24 bit inspect_leader and it works, like it worked before.
Let's wait to see what Luis can find out (Please take your time) :howdy

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by sympatyk » 2019-12-01 09:53, Sunday

I don't understand one -> why create an additional inspect_leader file -> if the same effect can be achieved with the inspect_portrait file ?
Has it ever been like this -> no inspect_portrait file -> the game takes pictures from the dossier_portrait file?

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-12-01 10:18, Sunday

sympatyk wrote:
2019-12-01 09:53, Sunday
I don't understand one -> why create an additional inspect_leader file -> if the same effect can be achieved with the inspect_portrait file ?
Has it ever been like this -> no inspect_portrait file -> the game takes pictures from the dossier_portrait file?
I did not create an additional inspect_leader.png file. I renamed my inspect_portrait.png file.
It is still the same png file, just an other name. Somehow it works for me :dunno

But this has nothing to do with the dossier_portrait. This one workes fine like ever for me.

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by lvjtn » 2019-12-01 10:26, Sunday

sympatyk wrote:
2019-12-01 09:53, Sunday
I don't understand one -> why create an additional inspect_leader file -> if the same effect can be achieved with the inspect_portrait file ?
Has it ever been like this -> no inspect_portrait file -> the game takes pictures from the dossier_portrait file?
dossier_portrait: it's used for the dossier panel, when you inspect your score, medals and total casualties inflicted (kill) and taken (loss). all nations have only one portrait, and its size (one picture) is 146x171

Image

------

inspect_leader: it was the original file using only one line for inspect unit panel. all nations have only one portrait, and its size (one picture) is 80x91

inspect_portrait: it was introduced later, when some efile makers asked an option to have different pictures for the max. 15 leaders, so all nations have 15 portraits (=15 lines), and its size (one column for a nation) is 80x1365

inspect_portrait is checked first and if not found inspect_leader is loaded

Image
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by lvjtn » 2019-12-01 10:27, Sunday

randowe wrote:
2019-12-01 10:18, Sunday
I did not create an additional inspect_leader.png file. I renamed my inspect_portrait.png file.
It is still the same png file, just an other name. Somehow it works for me :dunno
ok, that MAY be a problem. inspect_leader should have only 1 line (height should be 91px)
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-12-01 10:52, Sunday

lvjtn wrote:
2019-12-01 10:27, Sunday
randowe wrote:
2019-12-01 10:18, Sunday
I did not create an additional inspect_leader.png file. I renamed my inspect_portrait.png file.
It is still the same png file, just an other name. Somehow it works for me :dunno
ok, that MAY be a problem. inspect_leader should have only 1 line (height should be 91px)
Yes, and i have only one line! I had only one line since i started my efile. I want to keep the file size small.
(None of the guys using or testing my efile/Major Heinz campaign ever reported an issue with the file.)
I had just one line within the inspect_portrait which i used for more than a year until yesterday.
Then i had the bug and after hours of testing renamed my inspect_portrait -> inspect_leader.
And i just have one line within the inspect_leader which i use since yesterday.
It is the same one-line-file i use for a year, just an other name.

EDIT: But i seem to be the only one with an issue with the latest test exe. So maybe there is nothing wrong.
Let's wait and give Luis some time and maybe he can find something or not.

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by lvjtn » 2019-12-01 11:43, Sunday

randowe wrote:
2019-12-01 10:52, Sunday
I had just one line within the inspect_portrait
but it's a fault. the file dimension of the opengui/opendat files are fixed, and designers shouldn't change them. it was written several times. nobody should expect opengen working perfectly with unsupported file sizes, especially when there is a crystal clear way to use 1-line for leaders' portraits
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by sympatyk » 2019-12-01 13:02, Sunday

Hello Randowe
I saw the file - inspect_leader from 4/21/2019 -> it was valid
Color depth 24 bits per pixel (although 99 colors are used)

https://drive.google.com/file/d/1QHee7N ... sp=sharing

Csaba
And that you can't use an 8bit color file is a mistake! -> older versions of e-files had only 8bit files (256 colors)!

Luis
What is the difference between the portrait download algorithm from inspect_leader and inspect_portrait?
If inspect_portrait we limit the size to one line -> will cause error?

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-12-01 13:13, Sunday

lvjtn wrote:
2019-12-01 11:43, Sunday
randowe wrote:
2019-12-01 10:52, Sunday
I had just one line within the inspect_portrait
but it's a fault. the file dimension of the opengui/opendat files are fixed, and designers shouldn't change them. it was written several times. nobody should expect opengen working perfectly with unsupported file sizes, especially when there is a crystal clear way to use 1-line for leaders' portraits
:idea Now we speak the same language. So i made a fault when i was using a inspect_potrait with just one line :bonk I must admit until yesterday i didn't knew there is the option of the inspect_leader. I will use the one line inspect_leader from now on and the problem is solved :yes
I also think i knew what happened. When Cris had the problems with the textures, the exe was changed to load only part of the textures. Now when i use a one line inspect_potrait the exe cut it into 15 pieces, showing only a thin slice in game. So, like i said, the problem is solved by using inspect_leader. Thanks for your patience everybody :howdy

That leaves only the issue with the medals not updated.

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by LuisGuzman » 2019-12-01 21:49, Sunday

randowe wrote:
2019-12-01 13:13, Sunday
I also think i knew what happened. When Cris had the problems with the textures, the exe was changed to load only part of the textures. Now when i use a one line inspect_potrait the exe cut it into 15 pieces, showing only a thin slice in game. So, like i said, the problem is solved by using inspect_leader. Thanks for your patience everybody :howdy

That leaves only the issue with the medals not updated.
Effectively, the problem was that now dossier*.png and inspect*.png only load the pictures required to show in dossier or inspect dialogs, in order to allow loading in systems having limited texture's sizes, but when extracting the pictures needed, the alpha channel was left as zero if the png was using a palette of 256 colours (8 bits) resulting in an "invisible" image.

I've fixed, and now the alpha channel is set to 255 when loading the palette into the texture, and thus these png are loaded and show up properly regardless being 24 bits or 8 bits.

The other problem (photos and medals not changing according unit's country changes) is also fixed, as images are reloaded if country changes.

Can get OpenGenTest.exe 0.93.3.8.Test to check and confirm.

This fix should avoid the need to revert all those optimized OPENDAT's png files to be 24 bits :yes

:howdy
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
randowe
Second Lieutenant
Second Lieutenant
Posts: 395
Joined: 2019-09-20 19:02, Friday
Location: Brunswick, Germany

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by randowe » 2019-12-01 22:47, Sunday

LuisGuzman wrote:
2019-12-01 21:49, Sunday
randowe wrote:
2019-12-01 13:13, Sunday
I also think i knew what happened. When Cris had the problems with the textures, the exe was changed to load only part of the textures. Now when i use a one line inspect_potrait the exe cut it into 15 pieces, showing only a thin slice in game. So, like i said, the problem is solved by using inspect_leader. Thanks for your patience everybody :howdy

That leaves only the issue with the medals not updated.
Effectively, the problem was that now dossier*.png and inspect*.png only load the pictures required to show in dossier or inspect dialogs, in order to allow loading in systems having limited texture's sizes, but when extracting the pictures needed, the alpha channel was left as zero if the png was using a palette of 256 colours (8 bits) resulting in an "invisible" image.

I've fixed, and now the alpha channel is set to 255 when loading the palette into the texture, and thus these png are loaded and show up properly regardless being 24 bits or 8 bits.
This as not the issue i had, so i can not confirm :dunno I don't know what to do :huh
But as i wrote before, when i use the inspect_leader with one line, that solves my issue and works for me :yes
LuisGuzman wrote:
2019-12-01 21:49, Sunday
The other problem (photos and medals not changing according unit's country changes) is also fixed, as images are reloaded if country changes.
I can confirm, it is working :cool

User avatar
LuisGuzman
General, Special Forces
General, Special Forces
Posts: 140
Joined: 2019-03-10 08:35, Sunday
Location: Spain
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.7.Test (26-Nov-2019)

Post by LuisGuzman » 2019-12-02 10:50, Monday

randowe wrote:
2019-12-01 22:47, Sunday
This as not the issue i had, so i can not confirm :dunno I don't know what to do :huh
But as i wrote before, when i use the inspect_leader with one line, that solves my issue and works for me :yes
Yes, I know this was not your issue, but someone else (maybe Csaba) can confirm that the issue with png files made as 8 bits is fixed, so no need to revert the optimization of OPENDAT's png files. I've tested myself, buty I am the worst tester in the world :(
The other problem (photos and medals not changing according unit's country changes) is also fixed, as images are reloaded if country changes.
I can confirm, it is working :cool
Thanks for checking and confirming :bow
Image  Visit my site to get my latest tools.
* Click Open General banner to get more info about the game
Image

User avatar
lvjtn
General, VII. Upper Danubian Corps
General, VII. Upper Danubian Corps
Posts: 371
Joined: 2019-03-09 23:23, Saturday
Location: budapest / hungary
Contact:

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.8.Test (1-Dec-2019)

Post by lvjtn » 2019-12-02 12:03, Monday

LuisGuzman wrote:
2019-12-02 10:50, Monday
someone else (maybe Csaba) can confirm (...)
yep, i confirm, 8-bit leaders' portraits work now
»my real name is csaba (tʃɒbɒ)«
efiles:
Image Image Image Image Image

campaigns:
Image

Image

sympatyk
First Lieutenant
First Lieutenant
Posts: 59
Joined: 2019-10-03 17:05, Thursday

Re: OpenGen Questions & Bugs - Latest exe: 0.93.3.8.Test (1-Dec-2019)

Post by sympatyk » 2019-12-02 18:21, Monday

:howdy
Although late, I also confirm that it works with 8bit color
Through this discussion, I learned about the inspect_leader file and its properties
Thank

Post Reply